libs/ui-lib/lib/ocm/components/clusterDetail/clusterPropertiesUtils.tsx (1)

5-19: Simplify helpers by returning expressions directly

Both helpers are correct, but removing temporary mutable variables will make the code shorter and easier to scan.

♻️ Proposed refactor

 export const getNetworkType = (clusterNetworkType: Cluster['networkType']): string => {
-  let networkType: string;
-  clusterNetworkType === NETWORK_TYPE_SDN
-    ? (networkType = 'Software-Defined Networking (SDN)')
-    : (networkType = 'Open Virtual Network (OVN)');
-  return networkType;
+  return clusterNetworkType === NETWORK_TYPE_SDN
+    ? 'Software-Defined Networking (SDN)'
+    : 'Open Virtual Network (OVN)';
 };
 
 export const getManagementType = ({ userManagedNetworking }: Cluster): string => {
-  let managementType: string;
-  userManagedNetworking
-    ? (managementType = 'User-Managed Networking')
-    : (managementType = 'Cluster-managed networking');
-  return managementType;
+  return userManagedNetworking ? 'User-Managed Networking' : 'Cluster-managed networking';
 };

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@libs/ui-lib/lib/ocm/components/clusterDetail/clusterPropertiesUtils.tsx`
around lines 5 - 19, Replace the temporary mutable variables in getNetworkType
and getManagementType with direct expression returns: for getNetworkType return
the ternary expression based on clusterNetworkType (comparing to
NETWORK_TYPE_SDN) instead of assigning to networkType, and for getManagementType
return the ternary expression based on the Cluster's userManagedNetworking
property instead of assigning to managementType; update only those functions
(getNetworkType, getManagementType) to return the expressions directly.

libs/ui-lib/lib/ocm/components/clusterDetail/clusterPropertiesUtils.tsx (1)

5-11: Consider simplifying to a direct ternary return.

The intermediate variable and assignment-in-ternary pattern is verbose. A direct return is cleaner and more idiomatic.

♻️ Suggested simplification

 export const getNetworkType = (clusterNetworkType: Cluster['networkType']): string => {
-  let networkType: string;
-  clusterNetworkType === NETWORK_TYPE_SDN
-    ? (networkType = 'Software-Defined Networking (SDN)')
-    : (networkType = 'Open Virtual Network (OVN)');
-  return networkType;
+  return clusterNetworkType === NETWORK_TYPE_SDN
+    ? 'Software-Defined Networking (SDN)'
+    : 'Open Virtual Network (OVN)';
 };

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@libs/ui-lib/lib/ocm/components/clusterDetail/clusterPropertiesUtils.tsx`
around lines 5 - 11, The function getNetworkType currently uses an intermediate
variable and assignment inside a ternary; simplify it to return the string
directly from the ternary expression using the Cluster['networkType'] parameter
and the NETWORK_TYPE_SDN constant (i.e., replace the variable +
ternary-assignment pattern with a single return clusterNetworkType ===
NETWORK_TYPE_SDN ? 'Software-Defined Networking (SDN)' : 'Open Virtual Network
(OVN)').

libs/ui-lib/lib/ocm/components/clusterConfiguration/review/utils.tsx (1)

17-54: 'all' disk-encryption label should include arbiters.

case 'all' currently renders only control plane + workers, but other branches treat arbiters as a distinct role. This can under-report coverage in the UI when arbiters exist.

Proposed alignment fix

-    case 'all':
-      diskEncryptionType = (
-        <>
-          Enabled on control plane nodes
-          <br />
-          Enabled on workers
-        </>
-      );
-      break;
+    case 'all':
+    case 'masters,arbiters,workers':
+      diskEncryptionType = (
+        <>
+          Enabled on control plane nodes
+          <br />
+          Enabled on arbiters
+          <br />
+          Enabled on workers
+        </>
+      );
+      break;
@@
-    case 'masters,arbiters,workers':
-      diskEncryptionType = (
-        <>
-          Enabled on control plane nodes
-          <br />
-          Enabled on arbiters
-          <br />
-          Enabled on workers
-        </>
-      );
-      break;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@libs/ui-lib/lib/ocm/components/clusterConfiguration/review/utils.tsx` around
lines 17 - 54, The 'all' branch of the switch that sets diskEncryptionType only
mentions control plane nodes and workers and must also mention arbiters to match
other cases; update the switch case 'all' (variable diskEncryptionType) to
include "Enabled on arbiters" (with the same line-break formatting used in the
'masters,arbiters,workers' case) so the UI accurately reports disk encryption
for arbiters when all roles are selected.